Skip to content

Commit

Permalink
SPARK-51358 Make test less flaky
Browse files Browse the repository at this point in the history
  • Loading branch information
zecookiez authored and Zeyu Chen committed Mar 1, 2025
1 parent 958b491 commit 7ffadd8
Showing 1 changed file with 17 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,10 @@ class StateStoreCoordinatorSuite extends SparkFunSuite with SharedSparkContext {
}
}

test("snapshot uploads in RocksDB are not reported if changelog checkpointing is disabled") {
test(
"SPARK-51358: Snapshot uploads in RocksDB are not reported if changelog " +
"checkpointing is disabled"
) {
withCoordinatorAndSQLConf(
sc,
SQLConf.SHUFFLE_PARTITIONS.key -> "5",
Expand Down Expand Up @@ -198,7 +201,7 @@ class StateStoreCoordinatorSuite extends SparkFunSuite with SharedSparkContext {
}
}

test("snapshot uploads in RocksDB are properly reported to the coordinator") {
test("SPARK-51358: Snapshot uploads in RocksDB are properly reported to the coordinator") {
withCoordinatorAndSQLConf(
sc,
SQLConf.SHUFFLE_PARTITIONS.key -> "5",
Expand Down Expand Up @@ -242,8 +245,8 @@ class StateStoreCoordinatorSuite extends SparkFunSuite with SharedSparkContext {
}

test(
"snapshot uploads in RocksDBSkipMaintenanceOnCertainPartitionsProvider are properly " +
"reported to the coordinator"
"SPARK-51358: Snapshot uploads in RocksDBSkipMaintenanceOnCertainPartitionsProvider " +
"are properly reported to the coordinator"
) {
withCoordinatorAndSQLConf(
sc,
Expand Down Expand Up @@ -299,17 +302,17 @@ class StateStoreCoordinatorSuite extends SparkFunSuite with SharedSparkContext {
SymmetricHashJoinStateManager.allStateStoreNames(LeftSide, RightSide)

test(
"snapshot uploads for join queries with RocksDBStateStoreProvider are properly " +
"reported to the coordinator"
"SPARK-51358: Snapshot uploads for join queries with RocksDBStateStoreProvider " +
"are properly reported to the coordinator"
) {
withCoordinatorAndSQLConf(
sc,
SQLConf.SHUFFLE_PARTITIONS.key -> "5",
SQLConf.STREAMING_MAINTENANCE_INTERVAL.key -> "100",
SQLConf.SHUFFLE_PARTITIONS.key -> "3",
SQLConf.STREAMING_MAINTENANCE_INTERVAL.key -> "50",
SQLConf.STATE_STORE_MIN_DELTAS_FOR_SNAPSHOT.key -> "1",
SQLConf.STATE_STORE_PROVIDER_CLASS.key -> classOf[RocksDBStateStoreProvider].getName,
RocksDBConf.ROCKSDB_SQL_CONF_NAME_PREFIX + ".changelogCheckpointing.enabled" -> "true",
SQLConf.STATE_STORE_COORDINATOR_MIN_SNAPSHOT_VERSION_DELTA_TO_LOG.key -> "2"
SQLConf.STATE_STORE_COORDINATOR_MIN_SNAPSHOT_VERSION_DELTA_TO_LOG.key -> "4"
) {
case (coordRef, spark) =>
import spark.implicits._
Expand Down Expand Up @@ -354,18 +357,18 @@ class StateStoreCoordinatorSuite extends SparkFunSuite with SharedSparkContext {
}

test(
"snapshot uploads for join queries with RocksDBSkipMaintenanceOnCertainPartitionsProvider " +
"are properly reported to the coordinator"
"SPARK-51358: Snapshot uploads for join queries with " +
"RocksDBSkipMaintenanceOnCertainPartitionsProvider are properly reported to the coordinator"
) {
withCoordinatorAndSQLConf(
sc,
SQLConf.SHUFFLE_PARTITIONS.key -> "5",
SQLConf.STREAMING_MAINTENANCE_INTERVAL.key -> "100",
SQLConf.SHUFFLE_PARTITIONS.key -> "3",
SQLConf.STREAMING_MAINTENANCE_INTERVAL.key -> "50",
SQLConf.STATE_STORE_MIN_DELTAS_FOR_SNAPSHOT.key -> "1",
SQLConf.STATE_STORE_PROVIDER_CLASS.key ->
classOf[SkipMaintenanceOnCertainPartitionsProvider].getName,
RocksDBConf.ROCKSDB_SQL_CONF_NAME_PREFIX + ".changelogCheckpointing.enabled" -> "true",
SQLConf.STATE_STORE_COORDINATOR_MIN_SNAPSHOT_VERSION_DELTA_TO_LOG.key -> "2"
SQLConf.STATE_STORE_COORDINATOR_MIN_SNAPSHOT_VERSION_DELTA_TO_LOG.key -> "4"
) {
case (coordRef, spark) =>
import spark.implicits._
Expand Down

0 comments on commit 7ffadd8

Please sign in to comment.