Skip to content

Commit

Permalink
fix: dashboard image not get set in downstream due to devFlags config (
Browse files Browse the repository at this point in the history
…opendatahub-io#1224)

- if DSC CR has old format with empty devFlag:{}, it can cause downstream image not replace but run with quay.io one

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
  • Loading branch information
zdtsw authored Sep 5, 2024
1 parent c49b501 commit 1dbe269
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion components/dashboard/dashboard.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func (d *Dashboard) ReconcileComponent(ctx context.Context,
if err := d.cleanOauthClient(ctx, cli, dscispec, currentComponentExist, l); err != nil {
return err
}
if d.DevFlags != nil {
if d.DevFlags != nil && len(d.DevFlags.Manifests) != 0 {
// Download manifests and update paths
if err := d.OverrideManifests(ctx, platform); err != nil {
return err
Expand Down

0 comments on commit 1dbe269

Please sign in to comment.