fix duplication of images in dark mode #252
Conversation
Reviewer's Guide by SourceryThe PR fixes a CSS issue where images were being duplicated in dark mode by correcting the CSS selector syntax and removing redundant rules. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
WalkthroughThe changes in this pull request involve updates to the Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Hey @makotot - I've reviewed your changes - here's some feedback:
Overall Comments:
- The added
.lightselector is redundant withhtml:not(.dark). Please remove the redundant selector and just fix the duplicatedisplay: nonedeclaration in the original rule.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
docs/.vitepress/theme/custom.css
Outdated
| html:not(.dark) .vp-doc img[src$='#dark'] { | ||
| display: none; | ||
| } | ||
|
|
||
| .light .vp-doc img[src$='#dark'] { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
Remove redundant selector to fix image duplication.
The image duplication issue is likely caused by having two different selectors targeting the same condition:
html:not(.dark)(non-standard approach).light(VitePress's recommended approach)
When both selectors match, they can cause unexpected behavior during theme transitions.
Remove the non-standard selector to fix the duplication:
-html:not(.dark) .vp-doc img[src$='#dark'] {
- display: none;
-}
-
.light .vp-doc img[src$='#dark'] {
display: none;
}The .light class is VitePress's official way to handle light theme styles, so we should stick to it for better compatibility and maintainability.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| html:not(.dark) .vp-doc img[src$='#dark'] { | |
| display: none; | |
| } | |
| .light .vp-doc img[src$='#dark'] { | |
| display: none; | |
| } | |
| .light .vp-doc img[src$='#dark'] { | |
| display: none; | |
| } |
Fix duplication of images in dark mode in https://velite.js.org/guide/introduction . The current CSS syntax is incorrect.
Summary by Sourcery
Bug Fixes:
Summary by CodeRabbit
New Features
Bug Fixes