-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improvements #201
docs: improvements #201
Conversation
WalkthroughThis update improves the documentation for the Velite tool by correcting grammatical errors, enhancing clarity, and standardizing capitalization across multiple files. The adjustments focus on making the text more professional and user-friendly, ensuring that users have a clearer understanding of Velite's features and functionalities without altering any underlying content or logic. Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
docs/guide/using-mdx.md (1)
245-245
: Consider using a stronger adjective.The phrase "bundling MDX can be a good option for better portability" can be strengthened by using a different adjective. Consider using "excellent" or "optimal" instead of "good".
Tools
LanguageTool
[style] ~245-~245: Consider using a different adjective in this context to strengthen your wording.
Context: ...ased output size, bundling MDX can be a good option for better portability. You can...(GOOD_ALTERNATIVE)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (17)
- docs/.vitepress/config.ts (1 hunks)
- docs/examples/basic.md (1 hunks)
- docs/examples/nextjs.md (1 hunks)
- docs/guide/code-highlighting.md (5 hunks)
- docs/guide/custom-loader.md (1 hunks)
- docs/guide/custom-schema.md (2 hunks)
- docs/guide/define-collections.md (6 hunks)
- docs/guide/introduction.md (3 hunks)
- docs/guide/last-modified.md (2 hunks)
- docs/guide/quick-start.md (1 hunks)
- docs/guide/using-markdown.md (1 hunks)
- docs/guide/using-mdx.md (8 hunks)
- docs/guide/velite-schemas.md (1 hunks)
- docs/guide/with-nextjs.md (2 hunks)
- docs/other/snippets.md (2 hunks)
- docs/reference/config.md (1 hunks)
- readme.md (1 hunks)
Files skipped from review due to trivial changes (9)
- docs/.vitepress/config.ts
- docs/guide/custom-loader.md
- docs/guide/custom-schema.md
- docs/guide/introduction.md
- docs/guide/quick-start.md
- docs/guide/using-markdown.md
- docs/guide/velite-schemas.md
- docs/reference/config.md
- readme.md
Additional context used
Markdownlint
docs/examples/basic.md
55-55: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
docs/examples/nextjs.md
72-72: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
LanguageTool
docs/guide/with-nextjs.md
[uncategorized] ~5-~5: The preposition ‘to’ seems more likely in this position.
Context: ...cluding Next.js. Here are some recipes for help you better integrate Velite with N...(AI_HYDRA_LEO_REPLACE_FOR_TO)
docs/guide/define-collections.md
[style] ~89-~89: Consider removing “of” to be more concise
Context: ...rt of Zod'sz
object, and it supports all of the features of Zod. See [Zod's Docs](https...(ALL_OF_THE)
docs/guide/using-mdx.md
[misspelling] ~24-~24: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...tent/posts/hello-world.mdx` document is a MDX document with the following content...(EN_A_VS_AN)
[misspelling] ~131-~131: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...ild time. There is no need to construct a import tree. This can help reduce outpu...(EN_A_VS_AN)
[misspelling] ~172-~172: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...ents you want in your MDX files without a import. ::: code-group ```mdx [./post...(EN_A_VS_AN)
[style] ~245-~245: Consider using a different adjective in this context to strengthen your wording.
Context: ...ased output size, bundling MDX can be a good option for better portability. You can...(GOOD_ALTERNATIVE)
Additional comments not posted (34)
docs/examples/basic.md (1)
55-55
: Clarify command instruction.The change improves the clarity of the instruction by changing "run build with watch mode" to "run build in watch mode." This makes the instruction more precise and user-friendly.
Tools
Markdownlint
55-55: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
docs/guide/last-modified.md (9)
3-4
: Improved clarity in introductory text.The rephrasing of the introductory text improves clarity by explicitly stating that users can create a custom schema for displaying last modified times.
5-7
: Improved clarity in list items.The list items have been rephrased to be more concise and clear.
11-11
: Improved section title.The section title has been updated to clearly indicate that it is based on file stat.
14-15
: Added necessary imports.The imports for
stat
anddefineSchema
are explicitly added, ensuring that all necessary modules are clearly defined at the beginning of the code block.
17-28
: Enhanced structure and readability of thetimestamp
function.The
timestamp
function now usesdefineSchema
from thevelite
library, replacing the previous inline function declaration. This change enhances the structure and readability of the code.
31-31
: Improved usage example.The usage example has been updated to reflect the new schema definition approach.
46-49
: Added necessary imports.The imports for
exec
,promisify
, anddefineSchema
are explicitly added, ensuring that all necessary modules are clearly defined at the beginning of the code block.
52-62
: Enhanced structure and readability of thetimestamp
function.The
timestamp
function now usesdefineSchema
from thevelite
library, replacing the previous inline function declaration. This change enhances the structure and readability of the code.
65-65
: Improved usage example.The usage example has been updated to reflect the new schema definition approach.
docs/examples/nextjs.md (1)
72-72
: Clarify command instruction.The change improves the clarity of the instruction by changing "run build with watch mode" to "run build in watch mode." This makes the instruction more precise and user-friendly.
Tools
Markdownlint
72-72: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
docs/guide/code-highlighting.md (6)
3-3
: Improved Clarity and ConcisenessThe rephrased sentence improves clarity by explaining why Velite does not include built-in code highlighting and how users can implement it themselves.
39-39
: Enhanced ExplanationThe updated explanation clarifies that
rehype-pretty-code
creates the HTML structure for syntax highlighting and provides a clear instruction on adding styles.
79-79
: Reference to ExamplesThe added reference to examples enhances the documentation by providing users with a resource for more details.
166-166
: Clarification on Client-side HighlightingThe refined sentence specifies that using libraries like PrismJS or Shiki does not add build overhead, which is a significant point for users concerned about performance.
168-168
: Example Code for Client-side HighlightingThe added example code for client-side highlighting using Shiki improves the documentation by providing a practical implementation.
180-180
: Improved ReadabilityThe rephrased recommendation for processing a large number of documents improves readability and emphasizes the time-consuming nature of syntax highlighting.
docs/guide/with-nextjs.md (2)
5-5
: Grammatical CorrectionThe corrected phrase "Here are some recipes" enhances grammatical accuracy.
Tools
LanguageTool
[uncategorized] ~5-~5: The preposition ‘to’ seems more likely in this position.
Context: ...cluding Next.js. Here are some recipes for help you better integrate Velite with N...(AI_HYDRA_LEO_REPLACE_FOR_TO)
36-36
: Standardized CapitalizationThe modification to "In
next.config.js
:" improves the overall readability by standardizing capitalization.docs/guide/define-collections.md (8)
3-3
: Improved ReadabilityThe corrected phrase "Velite helps you organize" enhances readability and grammatical correctness.
89-89
: Clarification on Zod UtilityThe refined explanation specifies that the
z
utility is a re-export of Zod'sz
object, clarifying its functionality.Tools
LanguageTool
[style] ~89-~89: Consider removing “of” to be more concise
Context: ...rt of Zod'sz
object, and it supports all of the features of Zod. See [Zod's Docs](https...(ALL_OF_THE)
107-107
: Enhanced DescriptionThe updated phrase "For more complex schemas" provides a clearer distinction in the context of schema complexity.
159-159
: Clarification on Transform ContextThe refined explanation emphasizes the role of the
transform()
function in adding computed fields, improving clarity.
179-179
: Improved Grammatical StructureThe corrected phrase "loader keeps content's raw body" improves grammatical structure.
181-181
: Clarification on Custom Schema UsageThe updated explanation specifies that the
excerpt
function can take options, indicating a more flexible usage.
240-240
: Improved ExampleThe refined example for the
excerpt
function provides a clearer and more detailed explanation of its usage.
247-247
: Reference to Extended SchemaThe added reference to the
s.excerpt(options)
documentation enhances the user's understanding of the available options.docs/other/snippets.md (2)
8-22
: LGTM! The refactoring improves readability and maintainability.The use of
defineSchema
enhances the structure of the code. The logic for checking the input value and adding issues remains intact. The file's modified timestamp retrieval usingfs/promises
is correctly implemented.
37-53
: LGTM! The refactoring improves readability and maintainability.The use of
defineSchema
enhances the structure of the code. The logic for checking the input value and adding issues remains intact. The timestamp retrieval from Git logs usingexec
is correctly implemented.docs/guide/using-mdx.md (5)
12-12
: Improved clarity by adding hypothetical context.Changing "you have the following content structure" to "suppose you have the following content structure" adds hypothetical context, enhancing clarity.
24-24
: Correct grammatical error: Use "an" instead of "a".The phrase "a MDX document" should be "an MDX document" to be grammatically correct.
Tools
LanguageTool
[misspelling] ~24-~24: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...tent/posts/hello-world.mdx` document is a MDX document with the following content...(EN_A_VS_AN)
131-131
: Correct grammatical error: Use "an" instead of "a".The phrase "a import tree" should be "an import tree" to be grammatically correct.
Tools
LanguageTool
[misspelling] ~131-~131: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...ild time. There is no need to construct a import tree. This can help reduce outpu...(EN_A_VS_AN)
172-172
: Correct grammatical error: Use "an" instead of "a".The phrase "a import" should be "an import" to be grammatically correct.
Tools
LanguageTool
[misspelling] ~172-~172: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...ents you want in your MDX files without a import. ::: code-group ```mdx [./post...(EN_A_VS_AN)
215-215
: Improved flexibility and reusability of components.Adding global components to make them available to all MDX files enhances flexibility and reusability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
@qiushiyan Thanks a lot! |
Summary by CodeRabbit