Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to remove Sprout fields from the V5 transaction format. #453

Merged
merged 6 commits into from
Mar 17, 2021

Conversation

nuttycom
Copy link
Contributor

@nuttycom nuttycom commented Mar 3, 2021

This modification is suggested as a possible simplification as a result of this discussion in #446: https://github.com/zcash/zips/pull/446/files#r585949598

@nuttycom nuttycom mentioned this pull request Mar 3, 2021
6 tasks
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
@daira
Copy link
Collaborator

daira commented Mar 9, 2021

This proposal would prevent direct migration in a single transaction from Sprout to Orchard. I think that's fine, but we should have more consultation with the community about whether it is ok from a privacy point of view to migrate funds immediately to Orchard, rather than via a ZIP-308-like mechanism. (That's technically independent from this proposal, but interacts with it.)

Given a positive response from such consultation, I support this proposal because it sends a clear social signal that Sprout is "on its way out".

@dconnolly
Copy link
Contributor

I support this very much. Tying Sprout deprecation to V4 transactions alone, and when they are no longer supported, is very elegant from a maintainer's perspective to be able to just turn off anywhere V4 is supported and that turns off new Sprout processing. Also I think it will be an nice communication tool to communicate the how of Sprout deprecation to a community ('v4 transactions are going away, they are the only way Sprout funds can get out of the pool' or something like that).

@teor2345
Copy link
Contributor

teor2345 commented Mar 9, 2021

I think this is a great way to communicate another step in the sprout deprecation process: transfers out of the sprout pool are supported, but we're making concrete deprecation plans.

I also really like the ability to disable transaction v4 as a way of disabling sprout.

Copy link
Collaborator

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add the ZIP 222 reference and check the encCiphertext offset. Other suggestions are non-blocking.

nuttycom and others added 2 commits March 17, 2021 11:54
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Copy link
Collaborator

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. I'll generate the HTML and merge this.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@daira daira merged commit 9ab9857 into zcash:master Mar 17, 2021
@nuttycom nuttycom deleted the 225_remove-sprout-alternative branch March 17, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants