-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal to remove Sprout fields from the V5 transaction format. #453
Conversation
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
This proposal would prevent direct migration in a single transaction from Sprout to Orchard. I think that's fine, but we should have more consultation with the community about whether it is ok from a privacy point of view to migrate funds immediately to Orchard, rather than via a ZIP-308-like mechanism. (That's technically independent from this proposal, but interacts with it.) Given a positive response from such consultation, I support this proposal because it sends a clear social signal that Sprout is "on its way out". |
I support this very much. Tying Sprout deprecation to V4 transactions alone, and when they are no longer supported, is very elegant from a maintainer's perspective to be able to just turn off anywhere V4 is supported and that turns off new Sprout processing. Also I think it will be an nice communication tool to communicate the how of Sprout deprecation to a community ('v4 transactions are going away, they are the only way Sprout funds can get out of the pool' or something like that). |
I think this is a great way to communicate another step in the sprout deprecation process: transfers out of the sprout pool are supported, but we're making concrete deprecation plans. I also really like the ability to disable transaction v4 as a way of disabling sprout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add the ZIP 222 reference and check the encCiphertext
offset. Other suggestions are non-blocking.
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. I'll generate the HTML and merge this.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
This modification is suggested as a possible simplification as a result of this discussion in #446: https://github.com/zcash/zips/pull/446/files#r585949598