remove vendor, clean up module files and Makefile #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's better not to have the vendor directory; it was needed before modules worked well in Go. These days, the `go.mod` and `go.sum` files nail down the exact versions of each dependency as well as the vendor directory did. There are many modern Go projects, such as docker/compose, that don't have a vendor directory. So don't run `go vendor`, or if you do, don't git-add the files that are downloaded. Another advantage of removing the vendor directory is that the repo is only 9% of its former size. Another thing I did as part of this commit is to remove all the `require` lines in `go.mod` and then ran `go tidy`. This repopulated the require lines but with the latest versions. This may fix zcash#378 but I'm not sure (because I still see `gopkg.in/yaml.v2 v2.4.0 // indirect` in `go.mod`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's better not to have the vendor directory; it was needed before
modules worked well in Go. These days, the
go.modandgo.sumfilesnail down the exact versions of each dependency as well as the vendor
directory did. There are many modern Go projects, such as
docker/compose, that don't have a vendor directory.
So don't run
go vendor, or if you do, don't git-add the files thatare downloaded.
Another advantage of removing the vendor directory is that the repo is
only 9% of its former size.
Another thing I did as part of this commit is to remove all the
requirelines ingo.modand then rango tidy. This repopulated therequire lines but with the latest versions. This may fix #378 but I'm
not sure (because I still see
gopkg.in/yaml.v2 v2.4.0 // indirectin
go.mod.