-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release zcash_address 0.3.0, zcash_primitives 0.12.0 and zcash_proofs 0.12.0 #856
Conversation
@@ -91,7 +91,7 @@ impl ScanningKey for DiversifiableFullViewingKey { | |||
) -> Self::Nf { | |||
note.nf( | |||
key, | |||
u64::try_from(witness.tip_position()) | |||
u64::try_from(witness.position()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must be reverted prior to the next zcash_client_backend
release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #856 +/- ##
==========================================
- Coverage 71.48% 70.12% -1.36%
==========================================
Files 125 125
Lines 11862 11862
==========================================
- Hits 8479 8318 -161
- Misses 3383 3544 +161
☔ View full report in Codecov by Sentry. |
367f5e4
to
057fca0
Compare
057fca0
to
e7fb276
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Upgrades to:
bs58 0.5
incrementalmerkletree 0.4
orchard 0.5
Fixes zcash_primitives 0.12, zcash_proofs 0.12 #785