Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release zcash_address 0.3.0, zcash_primitives 0.12.0 and zcash_proofs 0.12.0 #856

Merged
merged 7 commits into from
Jun 6, 2023

Conversation

nuttycom
Copy link
Contributor

@nuttycom nuttycom commented Jun 6, 2023

Upgrades to:

@@ -91,7 +91,7 @@ impl ScanningKey for DiversifiableFullViewingKey {
) -> Self::Nf {
note.nf(
key,
u64::try_from(witness.tip_position())
u64::try_from(witness.position())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be reverted prior to the next zcash_client_backend release.

Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.36 ⚠️

Comparison is base (d2c5818) 71.48% compared to head (e7fb276) 70.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #856      +/-   ##
==========================================
- Coverage   71.48%   70.12%   -1.36%     
==========================================
  Files         125      125              
  Lines       11862    11862              
==========================================
- Hits         8479     8318     -161     
- Misses       3383     3544     +161     
Impacted Files Coverage Δ
zcash_client_backend/src/welding_rig.rs 50.37% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nuttycom nuttycom force-pushed the release/primitives_0.12-etc branch from 057fca0 to e7fb276 Compare June 6, 2023 21:56
@nuttycom nuttycom changed the title Release zcash_primitives 0.12.0 and zcash_proofs 0.12.0 Release zcash_address 0.3.0, zcash_primitives 0.12.0 and zcash_proofs 0.12.0 Jun 6, 2023
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@nuttycom nuttycom merged commit d2f105e into main Jun 6, 2023
@nuttycom nuttycom deleted the release/primitives_0.12-etc branch June 6, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zcash_primitives 0.12, zcash_proofs 0.12
3 participants