Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_note_encryption: Add ShieldedOutput::ephemeral_key() -> EphemeralKeyBytes #400

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Jun 10, 2021

This replaces the ShieldedOutput::epk() -> &Domain::EphemeralPublicKey which could not be satisfied by output types that did not parse epk.

…ralKeyBytes`

This replaces the `ShieldedOutput::epk() -> &Domain::EphemeralPublicKey`
which could not be satisfied by output types that did not parse epk.
@str4d str4d added this to the Core Sprint 2021-22 milestone Jun 10, 2021
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #400 (c7c79d2) into master (3915abd) will decrease coverage by 0.06%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
- Coverage   62.97%   62.91%   -0.07%     
==========================================
  Files          86       86              
  Lines        8417     8407      -10     
==========================================
- Hits         5301     5289      -12     
- Misses       3116     3118       +2     
Impacted Files Coverage Δ
...h_primitives/src/transaction/components/sapling.rs 76.43% <50.00%> (ø)
zcash_primitives/src/sapling/note_encryption.rs 75.16% <66.66%> (-0.17%) ⬇️
components/zcash_note_encryption/src/lib.rs 68.96% <100.00%> (+1.14%) ⬆️
zcash_client_sqlite/src/chain/init.rs 33.33% <0.00%> (-66.67%) ⬇️
...imitives/src/transaction/components/transparent.rs 58.82% <0.00%> (-1.97%) ⬇️
...imitives/src/transaction/components/tze/builder.rs 43.93% <0.00%> (-1.52%) ⬇️
zcash_primitives/src/transaction/builder.rs 51.47% <0.00%> (-0.60%) ⬇️
zcash_client_sqlite/src/chain.rs 97.65% <0.00%> (-0.08%) ⬇️
zcash_client_sqlite/src/wallet/transact.rs 99.16% <0.00%> (-0.02%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3915abd...c7c79d2. Read the comment docs.

@str4d str4d merged commit cc533a9 into zcash:master Jun 10, 2021
@str4d str4d deleted the rework-shieldedoutput-api branch June 10, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants