Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tinystr_macros #18

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Add tinystr_macros #18

merged 1 commit into from
Aug 21, 2020

Conversation

zbraniecki
Copy link
Owner

Fixes #17.

@zbraniecki
Copy link
Owner Author

Here's a minimal attempt. I cheated a bit to save on pulling syn and quote but it should do the trick for now.

@sffc - lmk if that's what you need :)

@zbraniecki
Copy link
Owner Author

Btw. it works in const positions too!

sffc
sffc reviewed Jul 27, 2020
View reviewed changes
Copy link
Collaborator

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

macros/src/lib.rs Show resolved Hide resolved
@zbraniecki zbraniecki force-pushed the macros branch 2 times, most recently from c931243 to 5693d82 Compare July 28, 2020 22:11
@zbraniecki zbraniecki mentioned this pull request Aug 8, 2020
Closed
@sffc
Copy link
Collaborator

sffc commented Aug 19, 2020

Okay. Consider my comment about crate names as non-blocking. We have #20 to follow up on it.

@zbraniecki zbraniecki merged commit a857108 into master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth left review comments

@sffc sffc sffc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add macro
3 participants
@zbraniecki @sffc @Manishearth