Adjusted and improved the 'metfile_from_knmi' function and the 'Flux' object 'drainage' #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md
Changed the content data type of the MetFile from CSVTable to Table. Removed CSVTable from fields.py. Removed serialize_csv_table from serializers.py. Changed the functions metfile_from_csv and metfile_from_knmi. Added tests and test csv-files in test folder.
Because ruff was conflicting with prettier I couldnt do previous commit with passing all pre-commit hooks. In the end I committed without the hooks, but forgot this file which caused the problem (the definition of the variables list in metfile_from_knmi input).
The order of columns was not correct in the last commit, causing SWAP to crash. It is corrected now and tests are adjusted as well.
Variables can no longer be specified and only the required variables by SWAP are retrieved from knmi. Units are now properly converted. Added tests.
This was
linked to
issues
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metfile_from_knmi has been changed drastically. I didn't function well, with missing variables causing SWAP crashes and incorrect units. The DAILYMETEODATA table is now used, which comes with correct validation of the table headers (#60). The field
CSVTableand the serializerserialize_csv_tablewere deleted since it was not used by any other method. Variables retrieved from knmi are now fixed, to ensure proper formatting for SWAP (#63).Additionally, the drainage tables are now imported and used in the
drainagefiles (#58)