Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InvalidSubscription
ResponseError
only provides a stringified version of the Net/HTTPResponse.However the Web Push Protocol defines several possible responses;
https://developers.google.com/web/fundamentals/engage-and-retain/push-notifications/web-push-protocol#response_from_push_service
This PR adds the following first-class error types;
ExpiredSubscription
(404)PayloadTooLarge
(413)TooManyRequests
(429)It also adds the original Net/HTTPResponse error as an attribute on
ResponseError
.