Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sharding with empty inner chunk and index location start #2336

Merged

Conversation

brokkoli71
Copy link
Member

@brokkoli71 brokkoli71 commented Oct 11, 2024

In sharding, empty inner chunks get marked by setting nbytes and offset to -1 in the index array. When using index_location="start" the size of the index array will be added to the offset.

This PR will disable incrementing the offset for empty inner chunks (thus, it still contains -1)

may contribute to #2302

@jhamman jhamman added the V3 label Oct 11, 2024
@jhamman jhamman changed the base branch from v3 to main October 14, 2024 20:50
@jhamman
Copy link
Member

jhamman commented Oct 18, 2024

@brokkoli71 / @normanrz - can we close this now.

@normanrz normanrz marked this pull request as ready for review October 18, 2024 16:25
@normanrz normanrz self-assigned this Oct 18, 2024
@normanrz normanrz merged commit 5f3a512 into zarr-developers:main Oct 18, 2024
31 checks passed
@normanrz normanrz deleted the sharding-with-empty-inner-chunks branch October 18, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants