Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should we lint (some of?) or tests folder with mypy? This revealed some discrepancies between our type annotations and our usage in the tests, so I think it'd be good to include them. For example, some of the tests used something like
as a shorthand for
But the type for
shape
was justChunkCoords
, which istuple[int, ...]
. If we want to allow this, then I think it's probably best to update the types to make that clear.That said, there's a bunch of errors (399 remaining in
tests/v3
, 2009 intests
. Some of these are correct but annoying, like all theassert isinstance(arr, Array)
in this PR, which was needed to convince mypy thatzarr.open()
had returned an Array and not a Group.I'd propose adding
tests/v3
to the list of checked files.TODO: