Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce ruff/tryceratops rules (TRY) #2054

Merged
merged 5 commits into from
Aug 11, 2024
Merged

Enforce ruff/tryceratops rules (TRY) #2054

merged 5 commits into from
Aug 11, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Jul 23, 2024 •
edited
Loading

Ignore TRY003 for now. I don't like it in this context.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft July 23, 2024 14:36
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review July 23, 2024 16:46
jhamman
jhamman approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with these changes. Thanks @DimitriPapadopoulos!

@jhamman jhamman added the V3 label Aug 9, 2024
@DimitriPapadopoulos
Apply ruff/tryceratops rule TRY004
4961921 
TRY004 Prefer `TypeError` exception for invalid type
@DimitriPapadopoulos
Apply ruff/tryceratops rule TRY201
e64157c 
TRY201 Use `raise` without specifying exception name
@dstansby dstansby merged commit ff462cc into zarr-developers:v3 Aug 11, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DimitriPapadopoulos @jhamman @dstansby