Apply preview ruff rules #1942
Merged
Apply preview ruff rules #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RUF022 `__all__` is not sorted
cc19b78 to
c573bff
Compare
RUF029 Function is declared `async`, but doesn't `await` or use `async` features.
c573bff to
37546da
Compare
jhamman
approved these changes
Jun 2, 2024
d-v-b
pushed a commit
to d-v-b/zarr-python
that referenced
this pull request
Jun 4, 2024
* Apply ruff rule RUF022 RUF022 `__all__` is not sorted * Apply ruff rule RUF029 RUF029 Function is declared `async`, but doesn't `await` or use `async` features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues reported by
ruff check --preview.I have no experience using
asyncio, so I am not confident in theRUF029fixes.TODO: