Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup on codecs #1889

Merged
merged 4 commits into from
May 21, 2024
Merged

Followup on codecs #1889

merged 4 commits into from
May 21, 2024

Conversation

normanrz
Copy link
Member

  • Merges the codec batch mixins into the Codec ABC
  • Renames evolve to evolve_from_array_spec
  • Uses as_ndarray_like in the _v2 codecs. @madsbk maybe we can do even better?

@normanrz normanrz added the V3 label May 17, 2024
@normanrz normanrz requested a review from d-v-b May 17, 2024 08:00
@normanrz normanrz self-assigned this May 17, 2024
madsbk
madsbk approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice with some memory-type agnostic codecs!
I will start work on a PR that introduces a CUDA buffer, which these codecs should be able to handle as-is.

@normanrz normanrz merged commit 0c513fc into v3 May 21, 2024
21 checks passed
@normanrz normanrz deleted the v3-codec-followup branch May 21, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsbk madsbk madsbk approved these changes

@d-v-b d-v-b Awaiting requested review from d-v-b

Assignees

@normanrz normanrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@normanrz @madsbk