-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't import from tests #1601
Don't import from tests #1601
Conversation
Does anyone have a problem with merging this? It will unblock efforts to modernize the packaging of |
if nobody objects, I'm going to merge this in under 12 hours. |
@jhamman has offered to review, so I will hold off on merging unilaterally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @d-v-b! Just one question below.
This is going in with temporary release notes that distinguish between v2 and v3 contributions. When we merge v3 into main, we will revert this alteration to the release notes. |
In
main
,DummyStorageTransformer
is defined in the test suite and imported byzarr/storage/v3_storage_transformers
. Because the distributed version ofzarr
should not be importing code from the tests, I moved the definition ofDummyStorageTransformer
tozarr/storage/v3_storage_transformers
, and now the tests that use this class can import it like any other zarr code.In the test suite, I also changed imports of the form
from zarr.test.module.. import bla
tofrom .module import bla
.Both of these changes are necessary for moving to a
src/zarr
layout.xref: #1592