Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turned on isolated_build in tox.ini file #1210

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

DON-BRAN
Copy link
Contributor

fixes: #1209

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@joshmoore
Copy link
Member

Thanks, @DON-BRAN. Any idea why the build in #1158 didn't detect this?

@Saransh-cpp
Copy link
Contributor

Hmm, I think Zarr is not using tox in GitHub Action to run the tests or to build the package.

@DON-BRAN
Copy link
Contributor Author

Thanks, @DON-BRAN. Any idea why the build in #1158 didn't detect this?

Hello @joshmoore, I'm not sure of why the build at #1158 didn't detect this behavior. I came across some resources

https://tox.wiki/en/latest/example/package.html
tox-dev/tox#1523
pypa/pip#8437

@joshmoore
Copy link
Member

Hmm, I think Zarr is not using tox in GitHub Action to run the tests or to build the package.

That would certainly do it, @Saransh-cpp. 😄 I've filed #1211

@joshmoore
Copy link
Member

Getting this merged since others (like @steph237) have needed to set this flag in their PRs.

@joshmoore joshmoore merged commit e474947 into zarr-developers:main Oct 24, 2022
@DON-BRAN DON-BRAN deleted the update-tox branch October 24, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation fails to build locally
3 participants