getitems(): handle on_error="omit"

zarr-developers · Sep 13, 2022 · f05ee3a · f05ee3a
1 parent 89fa599
commit f05ee3a
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/zarr/_storage/store.py b/zarr/_storage/store.py
@@ -165,8 +165,13 @@ def getitems(
         if on_error != "omit":
             raise ValueError(f"{self.__class__} doesn't support on_error='{on_error}'")
 
-        # Please overwrite `getitems` to support non-default values of `meta_array`
-        return {k: self[k] for k in keys if k in self}
+        ret = {}
+        for k in keys:
+            try:
+                ret[k] = self[k]
+            except Exception:
+                pass  # Omit keys that fails
+        return ret
 
 
 class Store(BaseStore):