Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update c-blosc (v1) to 1.21.5 #500

Merged
merged 4 commits into from
Dec 22, 2023
Merged

Update c-blosc (v1) to 1.21.5 #500

merged 4 commits into from
Dec 22, 2023

Conversation

mkitti
Copy link
Contributor

@mkitti mkitti commented Dec 20, 2023 •
edited
Loading

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@mkitti
Copy link
Contributor Author

mkitti commented Dec 20, 2023 

/home/mkitti/review_temp/conda/3/x86_64/envs/zarrtest/compiler_compat/ld: build/temp.linux-x86_64-cpython-312/c-blosc/internal-complibs/zstd-1.5.5/decompress/huf_decompress.o: in function `HUF_decompress4X1_usingDTable_internal':
huf_decompress.c:(.text+0x3b86): undefined reference to `HUF_decompress4X1_usingDTable_internal_fast_asm_loop'
/home/mkitti/review_temp/conda/3/x86_64/envs/zarrtest/compiler_compat/ld: build/temp.linux-x86_64-cpython-312/c-blosc/internal-complibs/zstd-1.5.5/decompress/huf_decompress.o: relocation R_X86_64_PC32 against undefined hidden symbol `HUF_decompress4X1_usingDTable_internal_fast_asm_loop' can not be used when making a shared object
/home/mkitti/review_temp/conda/3/x86_64/envs/zarrtest/compiler_compat/ld: final link failed: bad value
collect2: error: ld returned 1 exit status
[numcodecs] command '/usr/bin/gcc' failed with exit code 1
Traceback (most recent call last):
  File "/home/mkitti/review_temp/conda/3/x86_64/envs/zarrtest/lib/python3.12/site-packages/setuptools/_distutils/unixccompiler.py", line 266, in link
    self.spawn(linker + ld_args)
  File "/home/mkitti/review_temp/conda/3/x86_64/envs/zarrtest/lib/python3.12/site-packages/setuptools/_distutils/ccompiler.py", line 1041, in spawn
    spawn(cmd, dry_run=self.dry_run, **kwargs)
  File "/home/mkitti/review_temp/conda/3/x86_64/envs/zarrtest/lib/python3.12/site-packages/setuptools/_distutils/spawn.py", line 70, in spawn
    raise DistutilsExecError(
distutils.errors.DistutilsExecError: command '/usr/bin/gcc' failed with exit code 1

@joshmoore
Copy link
Member

ICYMI: #461

@pep8speaks
Copy link

pep8speaks commented Dec 21, 2023 •
edited
Loading

Hello @mkitti! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-12-21 20:42:19 UTC

@mkitti
Update c-blosc (v1) to 1.21.5
8905146 
Compile .S assembly files via setup.py
Fix Python 3.8 by not including minizip/crypt.h
@mkitti mkitti force-pushed the mkitti-c-blosc-v1_21_5 branch from db7760d to 8905146 Compare December 21, 2023 08:52
@mkitti mkitti marked this pull request as ready for review December 21, 2023 08:53
@mkitti
Copy link
Contributor Author

mkitti commented Dec 21, 2023

This appears to be ready to go.

@mkitti mkitti mentioned this pull request Dec 21, 2023
Closed
7 tasks
@mkitti mkitti closed this Dec 21, 2023
@mkitti mkitti reopened this Dec 21, 2023
@mkitti
Copy link
Contributor Author

mkitti commented Dec 21, 2023

Maybe I should not have skipped ci...

@d-v-b
Copy link
Contributor

d-v-b commented Dec 21, 2023

Anyone know what's blocking the github actions here?

@joshmoore
Copy link
Member

No. It might be something with the orgs used resources.

mkitti
mkitti commented Dec 21, 2023
View reviewed changes
@mkitti
Copy link
Contributor Author

mkitti commented Dec 21, 2023

I added a period and did not skip CI this time. All tests pass. Let's upgrade Blosc1! It's been three years...

@d-v-b
Copy link
Contributor

d-v-b commented Dec 21, 2023

Any objections to getting this in?

@d-v-b d-v-b merged commit b429e4b into zarr-developers:main Dec 22, 2023
26 checks passed
DimitriPapadopoulos pushed a commit to DimitriPapadopoulos/numcodecs that referenced this pull request Aug 10, 2024
@mkitti @d-v-b @DimitriPapadopoulos
Update c-blosc (v1) to 1.21.5 (zarr-developers#500)
39c6039 
* Update c-blosc (v1) to 1.21.5

Compile .S assembly files via setup.py
Fix Python 3.8 by not including minizip/crypt.h

* Add to release notes [skip ci]

* Update docs/release.rst

---------

Co-authored-by: Davis Bennett <davis.v.bennett@gmail.com>
This was referenced Aug 12, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to ZSTD 1.5.5 due to potential corruption
4 participants
@mkitti @joshmoore @pep8speaks @d-v-b