Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates examples to newer Icechunk syntax #431

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

norlandrhagen
Copy link
Collaborator

@norlandrhagen norlandrhagen commented Feb 6, 2025

PR to address #428.

  • Changes the Coiled example to write to Icechunk
  • Updates the NOAA append notebook to the newer icechunk syntax.

Blocked by: #421 and the related Zarr-python issue: zarr-developers/zarr-python#2800, so there might be some un-surfaced syntax errors that need addressing after.

@thodson-usgs should we also update your lithops example from the Kerchunk JSON format to Icechunk or would you like to leave it the way it is?

cc @abarciauskas-bgse

@TomNicholas TomNicholas added documentation Improvements or additions to documentation Icechunk 🧊 Relates to Icechunk library / spec labels Feb 11, 2025
@TomNicholas
Copy link
Member

This should be unblocked now FYI @norlandrhagen

@norlandrhagen
Copy link
Collaborator Author

The coiled example with icechunk seems to be working, but I might have broken you append example @abarciauskas-bgse.

icechunk: Version: 0.1.2

The store creation and appending all works great until I try to read the store at the end.

IcechunkError: Failed to decode variable 'time':   x error fetching virtual reference
  | 
  | context:
  |    0: icechunk::store::get
  |            with key="time/c/0" byte_range=From(0)
  |              at icechunk/src/store.rs:192
  | 
  |-> error fetching virtual reference
  |-> service error
  |-> unhandled error (PermanentRedirect)
  `-> Error { code: "PermanentRedirect", message: "The bucket you are attempting to access must be addressed using the specified endpoint. Please send all future requests to this endpoint.",
      s3_extended_request_id: "ngBa5W32GDyACUCx8CWH7aPoVJ2ghPOFOiztlHqgRIlp7kn65uAZLDkVQcc4ByM56O5KQTQM0mE=", aws_request_id: "W68YYTHWPYTN8WCM" }
 

Wondering if you've seen anything like this before @TomNicholas or @abarciauskas-bgse before I dig in further.

Also, I think the syntax moved or changed. virtual_ref_config/VirtualRefConfig

@TomNicholas
Copy link
Member

I don't recognize that error - any insight @mpiannucci ?

@mpiannucci
Copy link
Contributor

@norlandrhagen Take a look at the latest docs here https://icechunk--720.org.readthedocs.build/en/720/icechunk-python/virtual/

The syntax for virtual refs has changed most likely

@norlandrhagen
Copy link
Collaborator Author

The syntax for virtual refs has changed most likely

Thanks @mpiannucci! That fixed it.

@norlandrhagen
Copy link
Collaborator Author

I think this is G2G!

@TomNicholas
Copy link
Member

This looks good, except that in the append notebook, then because you didn't actually run the cell that commits the changes, the reading doesn't yet show the newly appended data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Icechunk 🧊 Relates to Icechunk library / spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants