-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added bash and zsh autocompletion #252
Conversation
fixed tview and runewidth dependencies in Gopkg.lock
Seems the build fails because it doesn't use |
Yeah we switch over to go modules recently. Likely you just need to upgrade to go1.11 and do something like |
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
+ Coverage 68.32% 68.34% +0.02%
==========================================
Files 42 43 +1
Lines 2251 2278 +27
==========================================
+ Hits 1538 1557 +19
- Misses 554 562 +8
Partials 159 159
Continue to review full report at Codecov.
|
Ah, didn't know about modules yet. I was looking for something like that but it seems i was blind and didn't expect the files to be called |
Added
bash
andzsh
autocompletion generation using cobra. This is based on the currently ongoing PR by babysnakes which i forked to support zsh custom completion for positional arguments.When babysnakes PR finally lands in cobra, the changes shouldn't differ too much.
The
bash
version simply completes the commands while thezsh
one has some additional argument completion (like menu completion of issue numbers with their title).added Gopkg files (dep)fixated 2 dependencies to an older commit in lock file (build problem)lab completion {bash,zsh}
commandThe
remote
argument of some commands is currently skipped. I started working on that, but this might be a good first iteration since most of it seems to work so far.see #40
changes made in my cobra fork can be seen here: babysnakes/cobra@zsh-completion...rsteube:zsh-completion-custom