Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests debugging dir and subdir names #44

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Conversation

adampie
Copy link
Member

@adampie adampie commented Sep 6, 2024

No description provided.

Signed-off-by: Adam Pietrzycki <adam@pietrzycki.com>
Signed-off-by: Adam Pietrzycki <adam@pietrzycki.com>
This commit eliminates unnecessary test cases for modified files, specifically removing references to "aws/workspaces/main.tf" and "gcp/workspaces/main.tf". This streamlines the test suite by ensuring it only focuses on the relevant "workspaces/main.tf" file.

Signed-off-by: Adam Pietrzycki <adam@pietrzycki.com>
Introduced unit tests for the workspaceForDir method in project_config_test.go to ensure accurate mapping of directories to TFC workspaces. Tests cover matching, non-matching, and similarly named subdirectory cases.

Signed-off-by: Adam Pietrzycki <adam@pietrzycki.com>
Introduce a series of unit tests to verify the functionality of the workspacesForTriggerDir method in the ProjectConfig class. Tests include scenarios with matching trigger directories, multiple workspaces, multiple trigger directories, and cases with no matching triggers.

Signed-off-by: Adam Pietrzycki <adam@pietrzycki.com>
@adampie adampie marked this pull request as ready for review October 24, 2024 14:28
@adampie adampie changed the title Debugging duplicate dir and subdir names Adding tests debugging dir and subdir names Oct 25, 2024
@MeNsaaH MeNsaaH merged commit 6e1c4d6 into zapier:main Nov 11, 2024
4 checks passed
sampsre pushed a commit that referenced this pull request Nov 29, 2024
* Adding extra tests

Signed-off-by: Adam Pietrzycki <adam@pietrzycki.com>

* Fix test

Signed-off-by: Adam Pietrzycki <adam@pietrzycki.com>

* Remove redundant test cases from project_config_test.go

This commit eliminates unnecessary test cases for modified files, specifically removing references to "aws/workspaces/main.tf" and "gcp/workspaces/main.tf". This streamlines the test suite by ensuring it only focuses on the relevant "workspaces/main.tf" file.

Signed-off-by: Adam Pietrzycki <adam@pietrzycki.com>

* Add tests for workspaceForDir in project_config_test.go

Introduced unit tests for the workspaceForDir method in project_config_test.go to ensure accurate mapping of directories to TFC workspaces. Tests cover matching, non-matching, and similarly named subdirectory cases.

Signed-off-by: Adam Pietrzycki <adam@pietrzycki.com>

* Add unit tests for workspacesForTriggerDir function

Introduce a series of unit tests to verify the functionality of the workspacesForTriggerDir method in the ProjectConfig class. Tests include scenarios with matching trigger directories, multiple workspaces, multiple trigger directories, and cases with no matching triggers.

Signed-off-by: Adam Pietrzycki <adam@pietrzycki.com>

---------

Signed-off-by: Adam Pietrzycki <adam@pietrzycki.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants