Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golang to 1.21.3 and alpine to 3.18 #79

Merged
merged 7 commits into from
Oct 24, 2023
Merged

Bump golang to 1.21.3 and alpine to 3.18 #79

merged 7 commits into from
Oct 24, 2023

Conversation

neiljain
Copy link
Contributor

@neiljain neiljain commented Oct 7, 2023

  • update versions in earthfile

@neiljain neiljain force-pushed the feature/update-golang-1-21 branch from 8a4d973 to ffec2a5 Compare October 7, 2023 09:43
@neiljain
Bump golang to 1.21.2 and alpine to 3.18
6a9ff59 
Signed-off-by: Neelesh Jain <neiljain@users.noreply.github.com>
@neiljain
Bump earthfile to use latest versions
815a1d7 
Signed-off-by: Neelesh Jain <neiljain@users.noreply.github.com>
@neiljain
Revert earthly version back to 0.6
523e439 
- Earthfile version is invalid, supported versions are [0.0 0.5 0.6]

Signed-off-by: Neelesh Jain <neiljain@users.noreply.github.com>
@neiljain neiljain force-pushed the feature/update-golang-1-21 branch from a1558b1 to 523e439 Compare October 8, 2023 22:49
@djeebus
Copy link
Collaborator

djeebus commented Oct 10, 2023

I believe you're going to have to bump the golang version in .tool-versions

@neiljain
Bump golang to 1.21.3
ceeed93 
Signed-off-by: Neelesh Jain <neiljain@users.noreply.github.com>
@neiljain neiljain changed the title Bump golang to 1.21.2 and alpine to 3.18 Bump golang to 1.21.3 and alpine to 3.18 Oct 10, 2023
@neiljain
Fix staticcheck 2023.1.6 download URL
f4644c4 
Signed-off-by: Neelesh Jain <neiljain@users.noreply.github.com>
@neiljain
Revert quintush/helm-unittest to v0.2.11
9d6f47c 
- its a fork of helm-unittest and no new releases since Jan there

Signed-off-by: Neelesh Jain <neiljain@users.noreply.github.com>
@neiljain
Copy link
Contributor Author

neiljain commented Oct 12, 2023 •
edited
Loading

I pushed a few more commits to resolve previous build failures, can we trigger the workflows again to see if that helps?

@djeebus
Copy link
Collaborator

djeebus commented Oct 12, 2023

While you're upgrading the world, you could swap from quintush/helm-unittest to helm-unittest/helm-unittest, which would let you upgrade it to 0.3.5

@neiljain
Revert helm chart testing versions
4b42401 
Signed-off-by: Neelesh Jain <neiljain@users.noreply.github.com>
@neiljain
Copy link
Contributor Author

I've instead reverted helm chart related changes to focus this PR only on golang and alpine updates. Best to look into helm chart unit testing related upgrade separately.

@djeebus
Copy link
Collaborator

djeebus commented Oct 22, 2023 •
edited
Loading

I've instead reverted helm chart related changes to focus this PR only on golang and alpine updates. Best to look into helm chart unit testing related upgrade separately.

good call. I approved the run, lets see how it goes!

@djeebus
Copy link
Collaborator

djeebus commented Oct 24, 2023

Success, thanks!

@djeebus djeebus merged commit 5047e63 into zapier:main Oct 24, 2023
6 checks passed
@neiljain neiljain deleted the feature/update-golang-1-21 branch October 24, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeebus djeebus djeebus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neiljain @djeebus