-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More natural swipe animations. #19
Conversation
I have to create a guide, I know, it's in the todo list. |
You can also add a script section to the package json, that's where the JavaScript folk (e.g me) looks for build scripts :) |
Btw, I went slightly overboard and removed a lot of repetition in the code (almost 20 lines less), but the important part are the ease-in and ease-out parameters of the transition. |
Built it yet. It has an issue, don't test/merge yet :) |
I forgot to mention that the last commit works fine, I'm enjoying this component a lot :) |
Changes all swipe animation easings to "ease-in" for the first half and "ease-out" for the second half.
You accidentally disabled swipe when animation=="none", which is the default. 😂 But don't worry, I fixed it. I took the liberty of rewording your commits as I'm adhering to conventional commits (yes, I know I need to create a CONTRIBUTING file). I hope it's not a problem. Anyway, thank you a lot for your contribution! Animations are now way snappier! I'm even thinking about using "swipe" as default. |
Happy to hear my changes were worth a merge! |
And yes, swipe feels nice :) I modified the default to swipe on my HA already. |
Don't worry, and good that you're willing to learn!
Yeah, the only way I (well, maykar to be precise) found to have a configuration is to piggyback the dashboard config. But I don't like it too much. |
|
v1.6.5 RC Looking fone so fat |
Changes all swipe animation easings to ease-in for the first half and ease-out for the second half
WARNING/SORRY: not tested.
How do you build this?