Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip_tabs not working #58

Closed
DarthSonic opened this issue Jul 15, 2023 · 5 comments
Closed

skip_tabs not working #58

DarthSonic opened this issue Jul 15, 2023 · 5 comments
Labels
🐛 bug Something isn't working

Comments

@DarthSonic
Copy link

I configured swipe_nav: in raw config of dashboard and set skip_tabs: 2 to skip the third tab. Tab is still shown on swipe.
@DarthSonic
Copy link
Author

Okay. Found a solution myself:

skip_tabs: 2,

works. So need to add a comma at the end. Should work without too IMHO or mentioned in documentation.

@zanna-37 zanna-37 added the 🐛 bug Something isn't working label Jul 16, 2023
@zanna-37
Copy link
Owner

Thank you very much for the issue!
This is indeed a bug and needs to be fixed. I wonder how it stayed there so long without being noticed.

zanna-37 pushed a commit that referenced this issue Aug 23, 2023
fix(core): do not panic when skip_tabs is a number
165a46f 
The config parameter `skip_tabs` is usually a string. However, when the user puts only one tab, it
is treated as a number, and the type system panics.

Ref. #58
@zanna-37
Copy link
Owner

Can you test the last pre-release (v1.12.1)? Everything should be working.

@DarthSonic
Copy link
Author

To be honest: I do not know how to test pre-releases ;-)

@zanna-37
Copy link
Owner

It's now available for everybody 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DarthSonic @zanna-37