Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create order request example amount field incorrect type #7

Merged

Conversation

thanhtinhpas1
Copy link
Contributor

I find out that the example CreateOrderRequest has a field number which wrong type, number instead of string. So this MR will fix that.

Note: I test this by code as the image below

image

Please take a look anh @anhldbk
IMHO if amount field goes along with currency or describes the default currency as VND will be better.

@anhldbk
Copy link
Member

anhldbk commented Apr 17, 2023

@leonthaibao PTAL

@anhldbk anhldbk requested a review from leonthaibao April 17, 2023 02:14
@leonthaibao
Copy link
Collaborator

Thanks @thanhtinhpas1 for your contribution.
About adding more description to the example of the readme. Because the default currency is VND so we don't have to add the currency field and the document should have precise detail on how to use the function not on the SDK readme. So for now, we will link the document to our SDK

@leonthaibao leonthaibao merged commit 961a218 into zalopay-oss:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants