feat: upgrade swagger dependencies (#1382) #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1382 +/- ##
=======================================
Coverage 87.46% 87.46%
=======================================
Files 49 49
Lines 734 734
Branches 55 55
=======================================
Hits 642 642
Misses 63 63
Partials 29 29 Continue to review full report at Codecov.
|
fcedd14 to
9048475
Compare
tkrop
commented
Apr 11, 2022
server/zally-core/src/test/kotlin/org/zalando/zally/core/DefaultContextFactoryTest.kt
Outdated
Show resolved
Hide resolved
tkrop
commented
Apr 11, 2022
...zally-ruleset-zally/src/test/kotlin/org/zalando/zally/ruleset/zally/PathParameterRuleTest.kt
Outdated
Show resolved
Hide resolved
9048475 to
8c1babb
Compare
ePaul
reviewed
Apr 12, 2022
server/zally-core/src/test/kotlin/org/zalando/zally/core/DefaultContextFactoryTest.kt
Outdated
Show resolved
Hide resolved
ePaul
reviewed
Apr 12, 2022
server/zally-core/src/main/kotlin/org/zalando/zally/core/ast/ReverseAstBuilder.kt
Show resolved
Hide resolved
1e8e5a0 to
1e2a62e
Compare
1e2a62e to
cbcb412
Compare
|
👍 |
tkrop
commented
Apr 14, 2022
| if (parsedAsSwagger !is ContentParseResult.NotApplicable) { | ||
| return parsedAsSwagger | ||
| } | ||
| return ContentParseResult.ParsedWithErrors(listOf(Violation("No valid Open API specification", EMPTY_JSON_POINTER))) |
There was a problem hiding this comment.
This is how the violation is triggered on the failed parsing.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1343.
contributes #1230.
Upgrade swagger dependencies to enable support for Open API 3.1. As it turned out while testing #1343 while migrating to JUnit 5 was actually disabling all tests through the missing dependency to the runtime. So we had to fix this first.
I also added a small fix of the Zally API actually defining Bearer Authentication.
Unfortunately, updating to the latest library is not sufficient for OpenAPI 3.1. Adding smoke test for Open API 3.1 support showed, that support for OpenAPI 3.1 in the latest swagger-parser version is still missing. Only swagger-core is ready for OpenAPI 3.1.
I finally added an improved failure handling on unsupported OpenAPI versions and unparsable files: They consistently now violate rule #101 of the guideline.