Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider setting @SupportedSourceVersion to SourceVersion.RELEASE_17 #1449

Closed
mkjensen opened this issue Apr 12, 2023 · 1 comment · Fixed by #1451
Closed

Consider setting @SupportedSourceVersion to SourceVersion.RELEASE_17 #1449

mkjensen opened this issue Apr 12, 2023 · 1 comment · Fixed by #1451

Comments

@mkjensen
Copy link
Contributor

mkjensen commented Apr 12, 2023

Since you are already preparing for Spring Boot 3 and Java 17 (#1433), maybe you can also consider changing https://github.com/zalando/zally/blob/main/server/zally-core/src/main/kotlin/org/zalando/zally/core/RuleProcessor.kt from @SupportedSourceVersion(SourceVersion.RELEASE_11) to @SupportedSourceVersion(SourceVersion.RELEASE_17).

Then we can avoid the following Maven warning in a Spring Boot 3 project:

[WARNING] Supported source version 'RELEASE_11' from annotation processor 'org.zalando.zally.core.RuleProcessor' less than -source '17'

Thanks.

@ePaul
Copy link
Member

ePaul commented May 2, 2023

Could you open a pull request for this? Then it can fit into the next release.

Thanks!

mkjensen added a commit to mkjensen/zally that referenced this issue May 4, 2023
mkjensen added a commit to mkjensen/zally that referenced this issue May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants