Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

refactor(opentracing): add tests and pass correct span contexts #236

Merged
merged 2 commits into from
May 29, 2018

Conversation

vigneshshanmugam
Copy link
Collaborator

  • Fix the issue when the parent span(handle-request) was getting finished before the child span(fetch-fragment) is finished.
  • Add tests for the opentracing instrumentation using MockTracer

'fragment-url': url,
'fragment-id': this.attributes.id || 'unnamed',
[Tags.SPAN_KIND]: Tags.SPAN_KIND_RPC_CLIENT,
url: url,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we know this is a fragment span from operation name so removed the fragment

@codecov
Copy link

codecov bot commented May 29, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@88c5850). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #236   +/-   ##
=========================================
  Coverage          ?   99.06%           
=========================================
  Files             ?       16           
  Lines             ?      642           
  Branches          ?      117           
=========================================
  Hits              ?      636           
  Misses            ?        6           
  Partials          ?        0
Impacted Files Coverage Δ
lib/request-handler.js 99% <100%> (ø)
lib/fragment.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88c5850...1241cf7. Read the comment docs.

@lmineiro
Copy link
Contributor

👍

@vigneshshanmugam
Copy link
Collaborator Author

👍

1 similar comment
@lmineiro
Copy link
Contributor

👍

@vigneshshanmugam vigneshshanmugam merged commit 4cdf914 into master May 29, 2018
@vigneshshanmugam vigneshshanmugam deleted the tracing-2 branch May 29, 2018 15:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants