This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
Integrate prettier #181
Merged
Integrate prettier #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vigneshshanmugam
commented
Sep 8, 2017
- prettier integration with eslint
vigneshshanmugam
commented
Sep 8, 2017
| "rules": { | ||
| "brace-style": [2, "1tbs"], |
There was a problem hiding this comment.
these options are removed from here to match with prettier defaults.
vigneshshanmugam
commented
Sep 8, 2017
| "strict": [2, "global"] | ||
| "strict": [2, "global"], | ||
| "prettier/prettier": [2, { | ||
| "singleQuote": true, |
There was a problem hiding this comment.
to match with quotes option in eslint
vigneshshanmugam
commented
Sep 8, 2017
| return Promise.resolve(new Transform(handledTags, insertBeforePipeTags)) | ||
| .then((transform => transform.applyTransforms(baseTemplate, childTemplate, fullRendering))); | ||
| }; | ||
| module.exports = (handledTags, insertBeforePipeTags) => ( |
There was a problem hiding this comment.
this module looks so much nicer.
vigneshshanmugam
commented
Sep 8, 2017
| '<fragment src="https://fragment/1"></fragment>' | ||
| ); | ||
|
|
||
| getResponse('http://localhost:8081/test') |
There was a problem hiding this comment.
the more deeper the function level gets, it gets really screwed up
|
👍 |
c2e97d5 to
8eba6d1
Compare
|
👍 |
1 similar comment
|
👍 |
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
=========================================
Coverage ? 97.25%
=========================================
Files ? 14
Lines ? 582
Branches ? 103
=========================================
Hits ? 566
Misses ? 16
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.