Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL 17 support #1049

Merged
merged 15 commits into from
Nov 19, 2024
Merged

PostgreSQL 17 support #1049

merged 15 commits into from
Nov 19, 2024

Conversation

hughcapet
Copy link
Member

  • Update extensions
  • Adjust scripts
  • Remove PG 12
  • Patroni 3.3.4
  • Use pkgs for timescaledb

@hughcapet hughcapet marked this pull request as ready for review November 19, 2024 11:28
@idanovinda
Copy link
Member

👍

1 similar comment
@hughcapet
Copy link
Member Author

👍

@hughcapet hughcapet merged commit 937815a into master Nov 19, 2024
4 of 6 checks passed
@hughcapet hughcapet deleted the dev-17 branch November 19, 2024 12:56
@chobostar
Copy link

Hi @hughcapet,

Would it be possible to build and push the container image based on this commit?

Here is the related issue for reference: zalando/spilo#1065

@hughcapet
Copy link
Member Author

hughcapet commented Dec 25, 2024

It is already built and pushed
https://github.com/zalando/spilo/pkgs/container/spilo-17

@chobostar
Copy link

Thanks for the feedback!

I noticed that the available builds are based on Patroni v4, which introduces breaking changes. The updated version doesn't seem mature enough yet, based on pull counters for Spilo container images:
spilo-17 : 634 pulls
spilo-16 : 37,782 pulls

The usage difference demonstrates that Spilo 16, which incorporates Patroni v3, is currently far more popular and well-established in production settings. Maintaining a container image with Patroni v3.3.4, which includes important reliability fixes, would still be highly valuable for the community.

Thank you for considering this request!

@hughcapet
Copy link
Member Author

hughcapet commented Dec 25, 2024

Current minor Patroni v4 release is mature enough. I can tell this as a maintainer and a user :)
Number of pulls only tells that spilo-17 is very new

spilo is just a dockerfile, highly customizable dockerfile. Image is built only for your convenience. We only maintain code — you can always build image yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants