Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

predicates/forwarded: use strings.Index to parse header #3405

Merged
merged 1 commit into from
Feb 14, 2025
Merged

predicates/forwarded: use strings.Index to parse header #3405

merged 1 commit into from
Feb 14, 2025

Conversation

AlexanderYastrebov
Copy link
Member

@AlexanderYastrebov AlexanderYastrebov commented Feb 11, 2025 •
edited
Loading

Use strings.Index instead of strings.Split to reduce memory allocations.

See #3403 for details.

@AlexanderYastrebov AlexanderYastrebov added the bugfix Bug fixes and patches label Feb 11, 2025
@AlexanderYastrebov AlexanderYastrebov force-pushed the predicates/forwarded/remove-strings-split branch 2 times, most recently from 66d3599 to 4356b7a Compare February 11, 2025 13:54
@AlexanderYastrebov AlexanderYastrebov changed the title predicates/forwarded: use strings.Cut to parse header predicates/forwarded: use strings.Index to parse header Feb 11, 2025
@AlexanderYastrebov AlexanderYastrebov force-pushed the predicates/forwarded/remove-strings-split branch 2 times, most recently from 1f4edb6 to d766a32 Compare February 11, 2025 13:57
@MustafaSaber
Copy link
Member

👍

@AlexanderYastrebov AlexanderYastrebov force-pushed the predicates/forwarded/remove-strings-split branch from d766a32 to 2b88519 Compare February 13, 2025 09:52
@AlexanderYastrebov
predicates/forwarded: use strings.Index to parse header
1eee42f 
Use strings.Index instead of strings.Split to reduce memory allocations.

See #3403 for details.

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
@AlexanderYastrebov AlexanderYastrebov force-pushed the predicates/forwarded/remove-strings-split branch from 2b88519 to 1eee42f Compare February 13, 2025 09:54
@MustafaSaber
Copy link
Member

👍

1 similar comment
@AlexanderYastrebov
Copy link
Member Author

👍

@AlexanderYastrebov AlexanderYastrebov merged commit 87b289c into master Feb 14, 2025
14 checks passed
@AlexanderYastrebov AlexanderYastrebov deleted the predicates/forwarded/remove-strings-split branch February 14, 2025 14:37
This was referenced Feb 17, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix Bug fixes and patches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderYastrebov @MustafaSaber