filters/auth: add host opt-out to jwtMetrics and oauthTokeninfoValidate #3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c4ecdea to
003f91c
Compare
| { | ||
| name: "no metrics when host matches opted-out domain", | ||
| filters: `jwtMetrics("{issuers: [foo, bar], optOutHosts: [ '^.+[.]domain[.]test$', '^exact[.]test$' ]}")`, | ||
| request: &http.Request{Method: "GET", Host: "foo.domain.test"}, |
There was a problem hiding this comment.
Should we test the same filter, but with "domain.test" host?
There was a problem hiding this comment.
We can but the goal is not to test regexp itself or all edge cases but the logic when host matches any or none of the configured patterns.
Extend configuration of `jwtMetrics` and `oauthTokeninfoValidate` to support opt-out by request host pattern - disable metrics collection and validation when request host matches any of the configured opt-out regular expressions. This can be used to exclude internal cluster domain (*.ingress.cluster.local hosts). Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
003f91c to
755df3d
Compare
|
👍 |
1 similar comment
|
👍 |
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Jul 25, 2024
* zalando/skipper#3167 * zalando/skipper#3166 * zalando/skipper#3165 * zalando/skipper#3164 * zalando/skipper#3162 * zalando/skipper#3161 * zalando/skipper#3159 * zalando/skipper#3158 * zalando/skipper#3070 * zalando/skipper#3140 * zalando/skipper#3155 [Changes](zalando/skipper@v0.21.150...v0.21.161) Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Jul 25, 2024
* zalando/skipper#3167 * zalando/skipper#3166 * zalando/skipper#3165 * zalando/skipper#3164 * zalando/skipper#3162 * zalando/skipper#3161 * zalando/skipper#3159 * zalando/skipper#3158 * zalando/skipper#3070 * zalando/skipper#3140 * zalando/skipper#3155 [Changes](zalando/skipper@v0.21.150...v0.21.161) Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
RomanZavodskikh
pushed a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Jul 26, 2024
* zalando/skipper#3167 * zalando/skipper#3166 * zalando/skipper#3165 * zalando/skipper#3164 * zalando/skipper#3162 * zalando/skipper#3161 * zalando/skipper#3159 * zalando/skipper#3158 * zalando/skipper#3070 * zalando/skipper#3140 * zalando/skipper#3155 [Changes](zalando/skipper@v0.21.150...v0.21.161) Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
szuecs
reviewed
Aug 12, 2024
| require.Equal(t, spec.Name(), f.Name) | ||
|
|
||
| _, err := spec.CreateFilter(f.Args) | ||
| t.Logf("%v", err) |
There was a problem hiding this comment.
does not assert.Error show the same thing?
There was a problem hiding this comment.
I think assert.Error does not log the error, only checks that is not nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend configuration of
jwtMetricsandoauthTokeninfoValidateto support opt-out by request host pattern - disable metrics collection and validation when request host matches any of the configured opt-out regular expressions.This can be used to exclude internal cluster domain (*.ingress.cluster.local hosts).