eskip: remove flowid dependency #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33de38e to
8109aad
Compare
eskip package is generally useful without proxy or filters and therefore ideally should have minimal number of dependencies. This change deprecates GenerateIfNeeded which is only used by etcd dataclient and reimplements it to remove dependency on github.com/zalando/skipper/filters/flowid See 35ba6cc Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
8109aad to
b032d6f
Compare
szuecs
reviewed
May 6, 2024
|
|
||
| // generate weak random id for a route if | ||
| // it doesn't have one. | ||
| // | ||
| // Deprecated: do not use, generate valid route id that matches [a-zA-Z_] yourself. |
There was a problem hiding this comment.
deprecate in the sense of stable?
If so, why do we need to deprecate it?
If we do not plan to delete it, then it's just fine and we do not need to apply the ignore SA1019
There was a problem hiding this comment.
To hint lib users to avoid it.
I'd also delete it in the future as it has strange API contract.
Or do you propose that we keep it or replace with something else?
There was a problem hiding this comment.
I just wanted to ask what the plan is, because the PR description nor commit does show what the plan is.
And you talked about deprecated is good because it means it is stable in the last days.
|
👍 |
1 similar comment
|
👍 |
This was referenced May 13, 2024
JanardhanSharma
pushed a commit
to JanardhanSharma/skipper
that referenced
this pull request
Jul 19, 2024
eskip package is generally useful without proxy or filters and therefore ideally should have minimal number of dependencies. This change deprecates GenerateIfNeeded which is only used by etcd dataclient and reimplements it to remove dependency on github.com/zalando/skipper/filters/flowid See 35ba6cc Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eskip package is generally useful without proxy or filters and therefore ideally should have minimal number of dependencies.
This change deprecates GenerateIfNeeded which is only used by etcd dataclient and reimplements it to remove dependency on github.com/zalando/skipper/filters/flowid
See 35ba6cc