OPA: Add tracing for outbound http calls #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Magnus Jungsbluth <magnus.jungsbluth@zalando.de>
szuecs
reviewed
Apr 22, 2024
Signed-off-by: Magnus Jungsbluth <magnus.jungsbluth@zalando.de>
3a49c72 to
0b4f305
Compare
|
Looks good modulo minor comments. |
Signed-off-by: Magnus Jungsbluth <magnus.jungsbluth@zalando.de>
|
👍 |
szuecs
reviewed
Apr 25, 2024
39f6af7 to
6811c23
Compare
Signed-off-by: Magnus Jungsbluth <magnus.jungsbluth@zalando.de>
6811c23 to
fa9c39c
Compare
|
👍 |
1 similar comment
|
👍 |
JanardhanSharma
pushed a commit
to JanardhanSharma/skipper
that referenced
this pull request
Apr 26, 2024
Signed-off-by: Magnus Jungsbluth <magnus.jungsbluth@zalando.de> Signed-off-by: Janardhan Sharma <janardhan.sharma@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the Open Policy Agent filters, tracing information is currently mainly added for the evaluation path of the filters. This is useful for monitoring everything that is related to requests passing through Skipper.
The PR adds tracing for asynchronous http calls that happen during discovery, bundle download, status updates and decision uppload. This allows to monitor how the OPA instances interact with their control plane.