script: support multiple header values #3013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `add` and `values` methods to set and get multiple header values. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
| if k:lower() == "authorization" then | ||
| table.insert(t, k) | ||
| table.insert(t, ": TRUNCATED\r\n") | ||
| else | ||
| table.insert(t, k) | ||
| table.insert(t, ": ") | ||
| table.insert(t, v) | ||
| table.insert(t, table.concat(header.values(k), " ")) |
There was a problem hiding this comment.
This is what logHeader filter does.
| @@ -677,6 +683,30 @@ func setRequestHeader(f filters.FilterContext) func(*lua.LState) int { | |||
| } | |||
| } | |||
|
|
|||
| func addRequestHeader(f filters.FilterContext) func(*lua.LState) int { | |||
There was a problem hiding this comment.
It should be possible to generalize this and reuse for request and response headers but for simplicity I decided to introduce separate functions to follow the style of existing single value setters/getters and also because they return closures.
szuecs
reviewed
Apr 8, 2024
| expectedRequestHeader: http.Header{ | ||
| "Foo": []string{"Bar", "Baz"}, | ||
| "Qux": []string{"Bar, Baz"}, | ||
| "Absent-Length": []string{"0"}, |
There was a problem hiding this comment.
Should we test Foo-Length (I expect it to be 2) and Qux-Length (I expect it to be 1) here as well?
There was a problem hiding this comment.
I added this case to show that length of empty values is zero
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
addandvaluesmethods to set and get multiple header values.