Created mock tests for ongoing Passive Health Check feature #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are three tests with the similar idea: 1) send a lot of requests 2) check for failure rate to be as expected 3) let endpointregistry update stats related to PHC 4) send a lot of requests 5) check for failure rate to be as expected after stats update The cases are: + single healthy endpoint + multiple healthy endpoints + multiple healthy + single unhealthy endpoint Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
szuecs
reviewed
Feb 14, 2024
| rnd *rand.Rand | ||
| } | ||
|
|
||
| type RoundTripperUnhealthyHostParams struct { |
There was a problem hiding this comment.
RoundTripperUnhealthyHostOptions?
szuecs
reviewed
Feb 14, 2024
| return rt.inner.RoundTrip(r) | ||
| } | ||
|
|
||
| func newRoundTripperUnhealthyHost(o *RoundTripperUnhealthyHostParams) func(r http.RoundTripper) http.RoundTripper { |
There was a problem hiding this comment.
o *RoundTripperUnhealthyHostParams why o if it's Params? So either rename or change o->p
|
👍 |
1 similar comment
|
👍 |
|
I will address Sandor's comments in #2888 or other subsequent PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three tests with the similar idea:
The cases are:
Splitted from #2888 to reduce amount of code merged in the single time.