Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plaintext for lightstep #40

Merged
merged 1 commit into from
Oct 5, 2020
Merged

add plaintext for lightstep #40

merged 1 commit into from
Oct 5, 2020

Conversation

vetinari
Copy link
Contributor

@vetinari vetinari commented Oct 5, 2020

set OPENTRACING_LIGHTSTEP_COLLECTOR_SCHEME=http to get this.
Can be used to connect to satellites offering just http connections

set OPENTRACING_LIGHTSTEP_COLLECTOR_SCHEME=http to get this.
Can be used to connect to satellites offering just http connections
@vetinari
Copy link
Contributor Author

vetinari commented Oct 5, 2020

👍

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #40 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   98.61%   98.63%   +0.01%     
==========================================
  Files           9        9              
  Lines         362      366       +4     
==========================================
+ Hits          357      361       +4     
  Misses          5        5              
Impacted Files Coverage Δ
opentracing_utils/tracers.py 86.84% <100.00%> (+1.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc2c2b7...802f602. Read the comment docs.

@marcinzaremba
Copy link

👍

@vetinari vetinari merged commit 1d344f7 into master Oct 5, 2020
@vetinari vetinari deleted the lightstep-plain branch October 5, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants