Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve resilience: continue on refresh failure if token is still valid #2

Closed
hjacobs opened this issue Dec 2, 2015 · 3 comments
Closed

Improve resilience: continue on refresh failure if token is still valid #2

hjacobs opened this issue Dec 2, 2015 · 3 comments
Assignees
@hjacobs
Labels
enhancement

Comments

@hjacobs
Copy link
Contributor

hjacobs commented Dec 2, 2015

Currently we fresh the token 20 minutes before it expires (https://github.com/zalando-stups/python-tokens/blob/master/tokens/__init__.py#L111). The refresh might fail, but the token is still valid.
"tokens.get(..)" should return the still valid token in this case (and log the refresh error).
@Jan-M
Copy link
Contributor

Jan-M commented Jan 8, 2016

This gets another +1, we just ran into lots of 400 bad request/client errors although there is time left

@hjacobs
Copy link
Contributor Author

hjacobs commented Jan 19, 2016

👍 from Frank

@hjacobs hjacobs self-assigned this Feb 3, 2016
hjacobs added a commit that referenced this issue Feb 3, 2016
@hjacobs
#2 return still valid token on failing refresh
6f7c026
hjacobs added a commit that referenced this issue Feb 3, 2016
@hjacobs
#2 apply suggestion by @jmcs
91292f4
hjacobs added a commit that referenced this issue Feb 3, 2016
@hjacobs
Merge pull request #3 from zalando-stups/2-use-valid-token-on-refresh…
4450c15 
…-failure

#2 return still valid token on failing refresh
@hjacobs
Copy link
Contributor Author

hjacobs commented Feb 3, 2016

Released in https://github.com/zalando-stups/python-tokens/releases/tag/1.0.13

@hjacobs hjacobs closed this as completed Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hjacobs hjacobs

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hjacobs @Jan-M