skipper: add config item for default authentication filters #7769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we enable default authentication using existing `skipper_default_filters_append`. This change adds a dedicated config item to separate default authentication filters from other default filters and make it easier to manage. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
| @@ -256,6 +256,7 @@ spec: | |||
| - "-disabled-filters={{ .Cluster.ConfigItems.skipper_disabled_filters }}" | |||
| {{ if ne .Cluster.ConfigItems.skipper_routesrv_enabled "exec" }} | |||
| - '-default-filters-prepend={{ .Cluster.ConfigItems.skipper_default_filters }}' | |||
| - '-default-filters-append={{ .Cluster.ConfigItems.skipper_default_filters_authentication }}' | |||
There was a problem hiding this comment.
Its OK to use empty flag value, see zalando/skipper#3084 and zalando/skipper#3127
|
👍 |
1 similar comment
|
👍 |
Merged
szuecs
reviewed
Jul 1, 2024
| @@ -541,6 +542,7 @@ spec: | |||
| - "-reverse-source-predicate" | |||
| - "-default-filters-dir=/etc/config/default-filters" | |||
| - '-default-filters-prepend={{ .Cluster.ConfigItems.skipper_default_filters }}' | |||
| - '-default-filters-append={{ .Cluster.ConfigItems.skipper_default_filters_authentication }}' | |||
There was a problem hiding this comment.
why creating a new config item for something we already have?
skipper_default_filters_append is already there
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we enable default authentication using existing
skipper_default_filters_append.This change adds a dedicated config item to separate default authentication filters from other default filters and make it easier to manage.