This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In #258 we talked about how there was a bit of a chicken and the egg situation with requires_finalizer. You proposed pulling the the requires_finalizer detection into
handle_resource_changing_cause
(option B).This pull request implements option B from that discussion, as I understood it.
Description
The need to add or remove a handler was detected in
detect_resource_changing_cause
in causation.py.The need to add or remove a handler will be detected in
handle_resource_changing_cause
in handling.py.N/A
Internal.
@nolar presented 2 possible options in another PR, this is the 2nd option.
Not that I can see, but i am not familiar with this code.
Issues/PRs
#258
Type of changes
Checklist
CONTRIBUTORS.txt