This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 87
Improve the GitHub issues/prs templates #278
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 zincr found 0 problems , 0 warnings
|
🤖 zincr found 1 problem , 0 warnings
Details on how to resolve are provided below ApprovalsAll proposed changes must be reviewed by project maintainers before they can be merged Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.
|
aweller
approved these changes
Jan 3, 2020
samurang87
reviewed
Jan 3, 2020
- [ ] I think the code is well written | ||
- [ ] Unit tests for the changes exist | ||
- [ ] Documentation reflects the changes | ||
- [ ] If you provide code modification, please add yourself to `CONTRIBUTORS.txt` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"modifications"
samurang87
reviewed
Jan 3, 2020
|
||
## Checklist | ||
|
||
- [ ] The code addresses only the mentioned problem, and this problem only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could use this line for myself lol
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Based on the experience of the past 9 months, improve the issue/pr templates by adding the guiding questions and the structure (e.g. in the Bug Reports).
Description
The original templates were taken from the Zalando's template repo and did not use the GitHub's new features.
Now, the new GitHub features will be used:
The code is not affected in any way. Just the GitHub interaction.
Issues/PRs
Type of changes
Checklist
CONTRIBUTORS.txt