Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Annotate all the code with the types #200

Merged
merged 9 commits into from
Oct 7, 2019

Conversation

nolar
Copy link
Contributor

@nolar nolar commented Oct 5, 2019

Add type-hints all over the code. Enable strict type-checker.

Issue : #194
Requires #199 first — due to unrelated external changes.

Description

After few preparational refactorings in #195, #196, #197, #198, the code is now ready to get all the type-hints for all the methods.

Generally, there are no behavioural changes. However, in some places, the code is changed to allow the type-checker to properly infer (guess) the type of variables.

The strict-mode type-checker is now a mandatory step of CI/CD. All the new code (functions, methods, classes) since now MUST be type-annotated.

Types of Changes

  • Refactor/improvements

@nolar nolar requested a review from samurang87 as a code owner October 5, 2019 09:22
@zincr
Copy link

zincr bot commented Oct 5, 2019

🤖 zincr found 0 problems , 1 warning

ℹ️ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Large Commits

Checks all commits for large additions to a single file. Large commits should be reviewed more carefully for potential copyright and licensing issues

This file contains a substantial change, please review to determine if the change comes from an external source and if there are any copyright or licensing issues to be aware of

  • ℹ️ kopf/reactor/registries.py had +100 lines of code changed in a single commit
    Please review this file to determine the source of this change
  • ℹ️ kopf/reactor/state.py had +100 lines of code changed in a single commit
    Please review this file to determine the source of this change
  • ℹ️ kopf/structs/bodies.py had +100 lines of code changed in a single commit
    Please review this file to determine the source of this change
     

thilp
thilp previously approved these changes Oct 5, 2019
kopf/cli.py Show resolved Hide resolved
kopf/clients/watching.py Show resolved Hide resolved
kopf/config.py Show resolved Hide resolved
kopf/reactor/registries.py Outdated Show resolved Hide resolved
kopf/reactor/registries.py Outdated Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactoring Code cleanup without new features added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants