This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
Obey the configured levels when posting from logging
#192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 zincr found 0 problems , 0 warnings |
samurang87
reviewed
Sep 26, 2019
kopf/engines/logging.py
Outdated
| @@ -39,9 +40,10 @@ def createLock(self): | |||
| def filter(self, record): | |||
| # Only those which have a k8s object referred (see: `ObjectLogger`). | |||
| # Otherwise, we have nothing to post, and nothing to do. | |||
| fit_lvl = record.levelno >= config.EventsConfig.events_loglevel | |||
There was a problem hiding this comment.
"Fits the minimal level condition". Some help with proper wording is appreciated.
There was a problem hiding this comment.
@samurang87 Fixed (probably).
samurang87
approved these changes
Sep 26, 2019
This was referenced Mar 26, 2020
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue with k8s-events posted for log messages despite the configured levels.
Description
Configured log levels was ignored in the connector of the
loggingfacilities to the k8s-event posting engine, so all events were posted. The docs were written for the event-posting shortcuts, but this was not taken into account when the log-posting engine was added.In addition, some extra checks are added to verify that the shortcuts actually obey the configured levels.
Note that the debug level messages are now filtered not by the K8s-posting handler
K8sPoster— the minimum level is removed from there— but by itsfilter()method, based on the Kopf's configs. Which is generally equivalent, as it was previously filtered by level insuper().filter(record), which stands in the same line.Types of Changes
Review
List of tasks the reviewer must do to review the PR