This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 87
Auto-guessing the peering mode #33
Labels
enhancement
New feature or request
Comments
@nolar I think it's better to not support |
s-soroosh
added a commit
to s-soroosh/kopf
that referenced
this issue
Apr 22, 2019
s-soroosh
added a commit
to s-soroosh/kopf
that referenced
this issue
Apr 22, 2019
s-soroosh
added a commit
to s-soroosh/kopf
that referenced
this issue
Apr 22, 2019
s-soroosh
added a commit
to s-soroosh/kopf
that referenced
this issue
Apr 22, 2019
s-soroosh
added a commit
to s-soroosh/kopf
that referenced
this issue
Apr 22, 2019
Co-Authored-By: psycho-ir <soroosh.sarabadani@gmail.com>
@psycho-ir Agree. Also, it is unclear what is meant if it is just a flag: which peering object to use. I've fixed the issue text. |
s-soroosh
added a commit
to s-soroosh/kopf
that referenced
this issue
Apr 23, 2019
nolar
added a commit
that referenced
this issue
Apr 24, 2019
[GH-33] implement auto detection mode for peering.
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Current Behaviour
Currently, the peering object is needed by default, unless
--standalone
option is used, which disables the peering completely.This causes the confusion for the first intro and following the tutorial — in case the cluster is not configured yet (no peering objects created). See: #31.
If standalone mode is made the default, there is a negative side-effect: if somebody runs 2+ operators —e.g. one in-cluster, another in the dev-mode on the external workstations— these operators will collide and compete for the objects without knowing this. The peering was invented exactly for the purpose of not hitting this issue in the dev-mode, and gracefully "suppressing" other operators.
Expected Behaviour
The peering should be considered as a side-feature for extra safety, it should not be a showstopper for the quick-start guides or tutorials.
It would be better to have 3 modes:
--peering
or--peering=something
, the peering is enforced, the operator fails to start if peering is not accessible (as it is now).--standalone
, the peering is ignored (as it is now).--namespace=
); if not found, log a big-letter warning of possible conflicts and collisions, and continue as if in the standalone mode.Relevant: #32.
Todos:
The text was updated successfully, but these errors were encountered: