Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ChannelManager): shouldCacheChannel getter #99

Merged
merged 2 commits into from
May 8, 2022
Merged

fix(ChannelManager): shouldCacheChannel getter #99

merged 2 commits into from
May 8, 2022

Conversation

DaStormer
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Fixed the shouldCacheChannel getter

Status

  • Code changes have been tested.

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@DaStormer DaStormer added bug Something isn't working pkg: guilded.js includes changes to guilded.js labels May 8, 2022
@DaStormer DaStormer requested a review from zaida04 May 8, 2022 06:10
@changeset-bot
Copy link

changeset-bot bot commented May 8, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 177f607

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
guilded.js Patch
@guildedjs/gil Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zaida04 zaida04 merged commit b3ddf90 into zaida04:main May 8, 2022
@renovate renovate bot mentioned this pull request May 19, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skillz4Killz Skillz4Killz Skillz4Killz approved these changes

@zaida04 zaida04 zaida04 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working pkg: guilded.js includes changes to guilded.js
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaStormer @zaida04 @Skillz4Killz