Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new calendar event props #217

Merged
merged 3 commits into from
Mar 17, 2023
Merged

feat: new calendar event props #217

merged 3 commits into from
Mar 17, 2023

Conversation

DaStormer
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Status

  • Code changes have been tested.

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@DaStormer DaStormer requested a review from zaida04 March 17, 2023 00:54
@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2023

🦋 Changeset detected

Latest commit: c188c8e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@guildedjs/guilded-api-typings Patch
guilded.js Patch
@guildedjs/rest Patch
@guildedjs/ws Patch
@guildedjs/gil Patch
@guildedjs/proxy-service Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

this.channelId = data.channelId;
this.serverId = data.serverId;
this.userId = data.userId;
this.status = data.status;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little redundant to put this in both the constructor and the update method if the constructor calls update.

@zaida04 zaida04 merged commit c86784a into main Mar 17, 2023
@zaida04 zaida04 deleted the feat-calendar-event-props branch March 17, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants