Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert embed objects to payload in message send #124

Merged
merged 1 commit into from
May 18, 2022

Conversation

zaida04
Copy link
Owner

@zaida04 zaida04 commented May 18, 2022

Please describe the changes this PR makes and why it should be merged:
This PR allows embeds to be converted to payloads in message send methods

Status

  • Code changes have been tested.

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@changeset-bot
Copy link

changeset-bot bot commented May 18, 2022

⚠️ No Changeset found

Latest commit: 10fd068

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zaida04 zaida04 requested a review from a team May 18, 2022 00:11
@zaida04 zaida04 added the pkg: guilded.js includes changes to guilded.js label May 18, 2022
@zaida04 zaida04 merged commit ebf3ebf into main May 18, 2022
@zaida04 zaida04 deleted the feat/embeds-convert branch May 18, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: guilded.js includes changes to guilded.js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants