Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We shouldn't allow a single click on the selected item #306

Closed
zadjii-msft opened this issue Jan 11, 2025 · 0 comments · Fixed by #347
Closed

We shouldn't allow a single click on the selected item #306

zadjii-msft opened this issue Jan 11, 2025 · 0 comments · Fixed by #347
Labels
Area-HostUX UX elements of the host CmdPal application Issue-Bug Something isn't working

Comments

@zadjii-msft
Copy link
Owner

zadjii-msft commented Jan 11, 2025

I can't tell you how often I just accidentally double-click on "All Apps", but end up activating "All Apps" then launching "ADB", because the first click activates the selected item, then the second click activates the selected item (on the next page).

While i'm here: single clicking should toss focus back at the search box, too

@zadjii-msft zadjii-msft added Issue-Bug Something isn't working Area-HostUX UX elements of the host CmdPal application labels Jan 11, 2025
zadjii-msft added a commit that referenced this issue Jan 21, 2025
Is your name Clint? Do you like settings? Did you hate that backspace on the
main page could dismiss the palette? If you said yes to any of that, you're in
luck! This PR is for you!

This PR adds three new settings:

* `BackspaceGoesBack`: Controls if backspace with an empty search takes you back
  a level
* `SingleClickActivates`: Allows users to toggle between the "single click
  selects, double activates" vs "single click activates" behavior
* `HighlightSearchOnActivate`: When `true` (**default**), this will select the
  text in the search bar when the window is summoned

This drive-by fixes a bug where clicking to select an item stole focus from the
search box.

closes #306
zadjii-msft added a commit that referenced this issue Jan 23, 2025
* Add 3 settings for Clint

Is your name Clint? Do you like settings? Did you hate that backspace on the
main page could dismiss the palette? If you said yes to any of that, you're in
luck! This PR is for you!

This PR adds three new settings:

* `BackspaceGoesBack`: Controls if backspace with an empty search takes you back
  a level
* `SingleClickActivates`: Allows users to toggle between the "single click
  selects, double activates" vs "single click activates" behavior
* `HighlightSearchOnActivate`: When `true` (**default**), this will select the
  text in the search bar when the window is summoned

This drive-by fixes a bug where clicking to select an item stole focus from the
search box.

closes #306

* spel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-HostUX UX elements of the host CmdPal application Issue-Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant